chore: update googleapis and regenerate#16609
chore: update googleapis and regenerate#16609jskeet wants to merge 6 commits intogoogleapis:mainfrom
Conversation
jskeet
added
the
do not merge
|
This is a prep-dry-run of step 7 of the migration process. (Even in the real thing, we'll close this PR...) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for DeploymentGroups in the google-cloud-config package, including the necessary API definitions, client methods, and generated samples. I have identified a few documentation issues, including a grammatical error in the DeploymentGroup docstring, an incorrect reference to a request message in the DeploymentUnit docstring, and a missing type hint in the GetDeploymentGroup client method docstring.
| r"""A DeploymentGroup is a collection of DeploymentUnits that in | ||
| a DAG-like structure. |
There was a problem hiding this comment.
Typo in DeploymentGroup docstring: "that in a DAG-like structure" is missing a verb. It should be "organized in a DAG-like structure" or "that form a DAG-like structure". This typo is also propagated to the client method docstrings.
| r"""A DeploymentGroup is a collection of DeploymentUnits that in | |
| a DAG-like structure. | |
| r"""A DeploymentGroup is a collection of DeploymentUnits organized in | |
| a DAG-like structure. |
| r"""A DeploymentUnit is a container for a deployment and its | ||
| dependencies. An existing deployment can be provided directly in the | ||
| unit, or the unit can act as a placeholder to define the DAG, with | ||
| the deployment specs supplied in a ``provisionDeploymentRequest``. |
There was a problem hiding this comment.
Typo in DeploymentUnit docstring: provisionDeploymentRequest should be ProvisionDeploymentGroupRequest to match the actual message name defined in this module.
| the deployment specs supplied in a ``provisionDeploymentRequest``. | |
| the deployment specs supplied in a ProvisionDeploymentGroupRequest. |
| print(response) | ||
|
|
||
| Args: | ||
| request (Union[google.cloud.config_v1.types.GetDeploymentGroupRequest, dict]): |
There was a problem hiding this comment.
The docstring for the request argument is missing the Optional type hint, although the method signature correctly defines it as Optional[...] = None. This inconsistency is present in multiple methods in this file and differs from the async_client.py implementation.
| request (Union[google.cloud.config_v1.types.GetDeploymentGroupRequest, dict]): | |
| request (Optional[Union[google.cloud.config_v1.types.GetDeploymentGroupRequest, dict]]): |
2 participants
Update googleapis to the latest commit and regenerate all client libraries.